Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hierarchy #38

Merged
merged 23 commits into from
Apr 22, 2024
Merged

Hierarchy #38

merged 23 commits into from
Apr 22, 2024

Conversation

audrey01mit
Copy link
Collaborator

Proposition to answer issue #31

  • Broke the hierarchy in devices.

  • The same can be done later for other modules more easily because generate_api and plot_images are automatized (no dependence on modules names).

  • Broke geometries in geometries (hyp tap etc...) and tests (alignment, resolution etc...), and design in design (classes) and cells (pre-built cells).

  • Updated documentation accordingly (check qnngds documentation for user and for dev).

  • Created a __default_param.py file to store the default values in functions over the entire module.

@audrey01mit audrey01mit requested a review from reed-foster April 18, 2024 21:40
@audrey01mit audrey01mit self-assigned this Apr 18, 2024
@audrey01mit audrey01mit linked an issue Apr 18, 2024 that may be closed by this pull request
src/qnngds/__init__.py Outdated Show resolved Hide resolved
Copy link
Contributor

@reed-foster reed-foster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I had a couple comments that should get addressed:

  • naming of nanowire.spot
  • removal of docstrings in plot_images
  • question about naming of __default_param

I had a few other more general comments, but I'll move those to separate issues, since they're not specifically relevant to this PR.

@reed-foster
Copy link
Contributor

Okay I created separate issues and replied to all the comments I originally left referencing those issues so that way only a few things need to be addressed here before merging.

@audrey01mit audrey01mit requested a review from reed-foster April 19, 2024 21:50
Copy link
Contributor

@reed-foster reed-foster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@audrey01mit audrey01mit merged commit ef1cb55 into master Apr 22, 2024
4 checks passed
@audrey01mit audrey01mit deleted the hierarchy branch April 22, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split up hierarchy
2 participants